Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release-1.7.2 #1476

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Release-1.7.2 #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ jobs:

- name: Add a GitHub comment if release has failed
uses: actions/github-script@v7
if: ${{ failure() && env.GITHUB_REPOSITORY != 'openshift-helm-charts/sandbox' }}
if: ${{ failure() && github.repository != 'openshift-helm-charts/sandbox' }}
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
Expand All @@ -555,14 +555,14 @@ jobs:
# This can be removed once the metrics execution is restructured to have access to the PR
# comment, or pulled out of the release job entirely.
- name: Retrieve PR comment for metrics
if: ${{ always() && needs.setup.outputs.run_build == 'true' && env.GITHUB_REPOSITORY != 'openshift-helm-charts/sandbox' }}
if: ${{ always() && needs.setup.outputs.run_build == 'true' && github.repository != 'openshift-helm-charts/sandbox' }}
run: |
mkdir -p $(dirname ${{ needs.chart-verifier.outputs.message_file }})
echo ${{ needs.chart-verifier.outputs.message_text_base64 }} | base64 -d | tee ${{ needs.chart-verifier.outputs.message_file }}

- name: Add metrics
id: add_metrics
if: ${{ always() && needs.setup.outputs.run_build == 'true' && env.GITHUB_REPOSITORY != 'openshift-helm-charts/sandbox' }}
if: ${{ always() && needs.setup.outputs.run_build == 'true' && github.repository != 'openshift-helm-charts/sandbox' }}
continue-on-error: true
env:
BOT_TOKEN: ${{ secrets.BOT_TOKEN }}
Expand Down
11 changes: 6 additions & 5 deletions scripts/src/packagemapping/generatelocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,12 @@ def main():
)
return 20

owners_content_loaded, owners_content = owners_file.get_owner_data_from_file(
filename
)
if not owners_content_loaded:
logError(f"Failed to load OWNERS file content. filename: {filename}")
try:
owners_content = owners_file.get_owner_data_from_file(filename)
except owners_file.OwnersFileError as of_err:
logError(
f"Failed to load OWNERS file content. filename: {filename} with error {of_err}"
)
return 30

owners_value_chart_name = owners_file.get_chart(owners_content)
Expand Down
Loading