-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support geopoint type for Tableau #1910
Open
GumpacG
wants to merge
5
commits into
opensearch-project:main
Choose a base branch
from
Bit-Quill:integ-geopoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey and
acarbonetto
as code owners
July 27, 2023 21:53
Codecov Report
@@ Coverage Diff @@
## main #1910 +/- ##
============================================
- Coverage 97.30% 97.30% -0.01%
+ Complexity 4623 4621 -2
============================================
Files 407 407
Lines 11935 11933 -2
Branches 828 830 +2
============================================
- Hits 11613 11611 -2
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthewryanwells
approved these changes
Jul 27, 2023
acarbonetto
previously approved these changes
Jul 27, 2023
integ-test/src/test/java/org/opensearch/sql/sql/GeoPointIT.java
Outdated
Show resolved
Hide resolved
opensearch/src/main/java/org/opensearch/sql/opensearch/data/utils/OpenSearchJsonContent.java
Show resolved
Hide resolved
Yury-Fridlyand
previously approved these changes
Jul 27, 2023
opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchGeoPointType.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
previously approved these changes
Jul 28, 2023
opensearch/src/main/java/org/opensearch/sql/opensearch/data/type/OpenSearchGeoPointType.java
Outdated
Show resolved
Hide resolved
...h/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprValueFactoryTest.java
Outdated
Show resolved
Hide resolved
matthewryanwells
approved these changes
Jul 28, 2023
* Added changes from POC PR Signed-off-by: Guian Gumpac <[email protected]> * Added geopoint parser for value factory Signed-off-by: Guian Gumpac <[email protected]> * Fixed old tests Signed-off-by: Guian Gumpac <[email protected]> * Fixed all old tests Signed-off-by: Guian Gumpac <[email protected]> * Removed irrelevant changes Signed-off-by: Guian Gumpac <[email protected]> * Removed irrelevant changes Signed-off-by: Guian Gumpac <[email protected]> * Added integration tests Signed-off-by: Guian Gumpac <[email protected]> * Fixed not throwing exception for geojson Signed-off-by: Guian Gumpac <[email protected]> * Made GeoPointValue an ExprTupleValue to enable access to lat and lon Signed-off-by: Guian Gumpac <[email protected]> * Fixed checkstyle Signed-off-by: Guian Gumpac <[email protected]> * Added unit tests and removed unnecessary code Signed-off-by: Guian Gumpac <[email protected]> * reverted irrelevant changes Signed-off-by: Guian Gumpac <[email protected]> * Added to docs Signed-off-by: Guian Gumpac <[email protected]> * Fixed doc typo Signed-off-by: Guian Gumpac <[email protected]> * Test doctests Signed-off-by: Guian Gumpac <[email protected]> * Test doctests Signed-off-by: Guian Gumpac <[email protected]> * Remove geopoint data from doctests Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest failure Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest failure Signed-off-by: Guian Gumpac <[email protected]> * Fix doctest clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Minimized doc example Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Fixed reordering of results Signed-off-by: Guian Gumpac <[email protected]> * Added more rows to doctests and removed IOException: Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Fixed doctest Signed-off-by: Guian Gumpac <[email protected]> * Addressed PR comments Signed-off-by: Guian Gumpac <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Yury-Fridlyand
previously approved these changes
Jul 31, 2023
acarbonetto
previously approved these changes
Aug 17, 2023
integ-test/src/test/java/org/opensearch/sql/sql/GeoPointIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
dismissed stale reviews from acarbonetto and themself
via
August 23, 2023 01:30
7286f9a
Yury-Fridlyand
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports geo_point by adding properties for lat and lon in order for Tableau/Power BI to access locations.
This PR will only support the format
{"lat": number, "lon": number}
.Geopoint will be treated as an
ExprTupleValue
to allow access to lat and lon properties.Expect results on Tableau when #1793 is resolved:
Follow up work:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.