Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support geopoint type for Tableau #1910

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Jul 27, 2023

Description

Supports geo_point by adding properties for lat and lon in order for Tableau/Power BI to access locations.
This PR will only support the format {"lat": number, "lon": number}.
Geopoint will be treated as an ExprTupleValue to allow access to lat and lon properties.

Expect results on Tableau when #1793 is resolved:
Screenshot 2023-07-10 at 8 18 32 AM

Follow up work:

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1910 (7286f9a) into main (ed2b683) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1910      +/-   ##
============================================
- Coverage     97.30%   97.30%   -0.01%     
+ Complexity     4623     4621       -2     
============================================
  Files           407      407              
  Lines         11935    11933       -2     
  Branches        828      830       +2     
============================================
- Hits          11613    11611       -2     
  Misses          315      315              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...h/sql/opensearch/data/type/OpenSearchDataType.java 100.00% <ø> (ø)
...l/opensearch/data/type/OpenSearchGeoPointType.java 100.00% <100.00%> (ø)
...l/opensearch/data/utils/OpenSearchJsonContent.java 100.00% <100.00%> (ø)
...search/data/value/OpenSearchExprGeoPointValue.java 100.00% <100.00%> (ø)

GumpacG and others added 2 commits July 31, 2023 09:01
* Added changes from POC PR

Signed-off-by: Guian Gumpac <[email protected]>

* Added geopoint parser for value factory

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed old tests

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed all old tests

Signed-off-by: Guian Gumpac <[email protected]>

* Removed irrelevant changes

Signed-off-by: Guian Gumpac <[email protected]>

* Removed irrelevant changes

Signed-off-by: Guian Gumpac <[email protected]>

* Added integration tests

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed not throwing exception for geojson

Signed-off-by: Guian Gumpac <[email protected]>

* Made GeoPointValue an ExprTupleValue to enable access to lat and lon

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed checkstyle

Signed-off-by: Guian Gumpac <[email protected]>

* Added unit tests and removed unnecessary code

Signed-off-by: Guian Gumpac <[email protected]>

* reverted irrelevant changes

Signed-off-by: Guian Gumpac <[email protected]>

* Added to docs

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doc typo

Signed-off-by: Guian Gumpac <[email protected]>

* Test doctests

Signed-off-by: Guian Gumpac <[email protected]>

* Test doctests

Signed-off-by: Guian Gumpac <[email protected]>

* Remove geopoint data from doctests

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest failure

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest failure

Signed-off-by: Guian Gumpac <[email protected]>

* Fix doctest clean up.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Minimized doc example

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed reordering of results

Signed-off-by: Guian Gumpac <[email protected]>

* Added more rows to doctests and removed IOException:

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Fixed doctest

Signed-off-by: Guian Gumpac <[email protected]>

* Addressed PR comments

Signed-off-by: Guian Gumpac <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Jul 31, 2023
@acarbonetto acarbonetto changed the title Support geopoint type Support geopoint type for Tableau Aug 17, 2023
@Yury-Fridlyand Yury-Fridlyand dismissed stale reviews from acarbonetto and themself via 7286f9a August 23, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] BI tools compliance with complex objects
4 participants