Fix issue with jwt attribute parsing of lists #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4884 +/- ##
==========================================
- Coverage 69.90% 69.86% -0.04%
==========================================
Files 320 320
Lines 21688 21706 +18
Branches 3460 3462 +2
==========================================
+ Hits 15160 15164 +4
- Misses 4734 4750 +16
+ Partials 1794 1792 -2
|
RyanL1997
reviewed
Nov 8, 2024
src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
willyborankin
approved these changes
Nov 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ddcecb5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue in the JWT authenticator when parsing a claim that contains a list value. The existing parsing logic works as-is, but the problem arises when you try to use the parsed value in a DLS clause using the
${attr.jwt.claim}syntax.Bug fix
Issues Resolved
Resolves: #4267
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.