-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.18] Fix remaining integ tests #4851
[2.18] Fix remaining integ tests #4851
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
…egrationTest Signed-off-by: Craig Perkins <[email protected]>
|
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.18 #4851 +/- ##
==========================================
+ Coverage 63.83% 63.86% +0.02%
==========================================
Files 330 330
Lines 23091 23091
Branches 3741 3741
==========================================
+ Hits 14741 14747 +6
+ Misses 6519 6512 -7
- Partials 1831 1832 +1 |
FYI The reason that the CI Check shows as green even when there are failing tests is because of the configuration here: https://github.com/opensearch-project/security/blob/main/build.gradle#L535-L541
The tests do pass on retry so the CI check is green. This configuration may be hiding some flakiness so we may want to start gathering stats on flaky tests to try to get all tests to pass consistently on first run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes integ tests that subclass AbstractApiIntegrationTest and are failing due to static initialization.
This PR introduces a new pattern for base class initialization that initializes once in the
@Before
block per base class and uses polymorphism to supply custom cluster settings for the tests in each base class.This PR also mutes the flaky tests
SecurityConfigurationTests.testParallelTenantPutRequests
and only runs ResourceFocusedTests as a PR check. Ideally, ResourceFocusedTests are also run with release time integ tests, but I ran into issues with memory exhaustion on the github runners.In a previous commit I had added memory to the integ tests, but I'd like to keep the defaults if possible.
Test fix
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.