[Enhancement] Input Validation for generate obo token endpoint #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3553 +/- ##
============================================
- Coverage 65.04% 64.99% -0.06%
+ Complexity 3644 3641 -3
============================================
Files 282 282
Lines 20597 20615 +18
Branches 3390 3393 +3
============================================
+ Hits 13397 13398 +1
- Misses 5518 5534 +16
- Partials 1682 1683 +1
|
Signed-off-by: Ryan Liang <[email protected]>
35 tasks
RyanL1997
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
stephen-crawford,
reta and
willyborankin
as code owners
There was a problem hiding this comment.
Thank you @RyanL1997 for this improvement. Left some minor suggestions.
src/integrationTest/java/org/opensearch/security/http/OnBehalfOfJwtAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <[email protected]>
DarshitChanpura
approved these changes
Oct 17, 2023
cwperks
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Input Validation for generate obo token endpoint
Enhancement
Issues Resolved
Testing
Integration Test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.