-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JWT authentication type to MultipleAuthentication #2107
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: merlinz01 <[email protected]>
5375372
to
804422a
Compare
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
At this point what I am seeing is that the session cookie is being lost (deleted) when the browser requests |
The request for The logic here
decides that the request needs authenticated. This line
is then called, which deletes the auth cookie. I assume this is not the desired behavior, and it seems like it would cause problems even without my changes. Any input? |
Signed-off-by: merlinz01 <[email protected]>
OK, I think I fixed the endless loop of the page refreshing with the above commit. |
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
+ Coverage 71.40% 73.91% +2.50%
==========================================
Files 97 97
Lines 2651 2649 -2
Branches 404 403 -1
==========================================
+ Hits 1893 1958 +65
+ Misses 642 641 -1
+ Partials 116 50 -66 ☔ View full report in Codecov by Sentry. |
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
@derek-ho @RyanL1997 @DarshitChanpura Could one of you take a look as well? |
Description
Allows JWT to be included in a multiple-authentication configuration.
Category
Enhancement
Why these changes are required?
Previously one cannot use basic auth and JWT auth together
What is the old behavior before changes and new behavior after changes?
OSD error when basic auth and JWT auth are configured
Issues Resolved
#1814
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.