Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom build script to support different cypress version #2027

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jul 12, 2024

Description

Adds custom build script to allow for different cypress version from core.

Category

Fix: #1786 hopefully

Why these changes are required?

Build repo not making the change so seeing if this will fix it from our end.

What is the old behavior before changes and new behavior after changes?

Should build successfully after

Issues Resolved

Fix: #1786

Testing

None possible, this would be picked up by the build infra

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member

cwperks commented Jul 12, 2024

Are there any testing steps that can be added to the PR description?

@derek-ho derek-ho marked this pull request as ready for review July 12, 2024 20:04
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derek-ho. Can we rename the file to build-opensearch-dashboards.sh? unless this will be the only build script in the repo.

@derek-ho
Copy link
Collaborator Author

Thanks @derek-ho. Can we rename the file to build-opensearch-dashboards.sh? unless this will be the only build script in the repo.

It needs to be named this way according to: https://github.com/opensearch-project/opensearch-build/blob/6f53f232978213fd3f278aece2f06c4f19e53549/ONBOARDING.md?plain=1#L26

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (293490d) to head (c6eb9c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2027   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          97       97           
  Lines        2600     2600           
  Branches      380      380           
=======================================
  Hits         1836     1836           
  Misses        668      668           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derek-ho derek-ho merged commit e35f7f7 into opensearch-project:main Jul 12, 2024
18 of 19 checks passed
@cwperks cwperks added the backport 2.x backport to 2.x branch label Jul 13, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 13, 2024
DarshitChanpura pushed a commit that referenced this pull request Jul 14, 2024
…2028)

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit e35f7f7)

Co-authored-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Distribution Build Failed for securityDashboards-3.0.0
3 participants