Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase accuracy seconds while testing create on-demand report from definition #1022

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rupal-bq
Copy link
Contributor

Description

  • Increased accuracy to 3 seconds to fix test create on-demand report from definition
Suite: Test class org.opensearch.integTest.rest.OnDemandReportGenerationIT
  2> REPRODUCE WITH: gradlew ':integTest' --tests "org.opensearch.integTest.rest.OnDemandReportGenerationIT.test create on-demand report from definition" -Dtests.seed=ED3578B41EEBF049 -Dtests.security.manager=false -Dtests.locale=et -Dtests.timezone=Etc/UCT -Druntime.java=21
  2> java.lang.AssertionError: 2024-07-26T01:37:49.953Z + 1 > 2024-07-26T01:37:51.613507800Z
        at __randomizedtesting.SeedInfo.seed([ED3578B41EEBF049:7D2AC1B193B3B17A]:0)
        at kotlin.test.DefaultAsserter.fail(DefaultAsserter.kt:16)
        at kotlin.test.Asserter$DefaultImpls.assertTrue(Assertions.kt:652)
        at kotlin.test.DefaultAsserter.assertTrue(DefaultAsserter.kt:11)
        at kotlin.test.Asserter$DefaultImpls.assertTrue(Assertions.kt:662)
        at kotlin.test.DefaultAsserter.assertTrue(DefaultAsserter.kt:11)
        at kotlin.test.AssertionsKt__AssertionsKt.assertTrue(Assertions.kt:44)
        at kotlin.test.AssertionsKt.assertTrue(Unknown Source)
        at org.opensearch.integTest.IntegTestHelpersKt.validateTimeNearRefTime(IntegTestHelpers.kt:57)
        at org.opensearch.integTest.rest.OnDemandReportGenerationIT.test create on-demand report from definition(OnDemandReportGenerationIT.kt:81)
  2> NOTE: leaving temporary files on disk at: C:\Users\ContainerAdministrator\tmpal3owpou\opensearch-reports\build\testrun\integTest\temp\org.opensearch.integTest.rest.OnDemandReportGenerationIT_ED3578B41EEBF049-001
  2> NOTE: test params are: codec=Asserting(Lucene99): {}, docValues:{}, maxPointsInLeafNode=125, maxMBSortInHeap=6.446428262016807, sim=Asserting(RandomSimilarity(queryNorm=true): {}), locale=et, timezone=Etc/UCT
  2> NOTE: Windows 10 10.0 amd64/Eclipse Adoptium 21.0.3 (64-bit)/cpus=16,threads=1,free=453955488,total=536870912
  2> NOTE: All tests run in this JVM: [InContextMenuReportGenerationIT, OnDemandReportGenerationIT]

Time difference in other runs

java.lang.AssertionError: 2024-07-26T01:34:22.333Z + 1 > 2024-07-26T01:34:23.375386678Z
java.lang.AssertionError: 2024-07-23T01:17:37.613Z + 1 > 2024-07-23T01:17:40.377426771Z

Unable to reproduce this error on local so probably infra setup requires more time.

Related Issues

Resolves #1019

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal Mahajan <[email protected]>
@derek-ho derek-ho merged commit c2fb2da into opensearch-project:main Jul 29, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit c2fb2da)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit c2fb2da)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit c2fb2da)

Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit c2fb2da)

Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Integration Test failed for opensearch-reports: 2.16.0
4 participants