Footer redesign & calendar update #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_sass/redesign_pallette.scss Added an array of gray to our color palette. This just explicitly allows us the lighter grays and puts them in context. These are used in the font coloring of the footer. _sass/footer.scss removed much of the old styling as it was not needed anymore. Much of it was there to support the rendering on mobile devices, which bootstrap now handles. Also i renamed categories to make it more clear which styles applied to what elements. _includes/footer.html total rip and replace. Its still a three column layout but it now uses bootstrap to render it. _Data/footer_social_links.yml Im not sure this will end up working, but I wanted to be able to iterate over all of the social links and be able to render them element by element. This will be used to create the array of social icons at the bottom of hte footer. Currently not working. _data/footer.yml changed the footer categories. Signed-off-by: kaimmej <[email protected]>
Added social sharing icons to the icons.html file. Converted the footer formatting to be rendered by bootstrap Signed-off-by: kaimmej <[email protected]>
the _sass/style.scss boxshadow element was interacting with the footer and causing the background element of hte footer to be clipped. removed. Added a row element to the 3column base layout. Formatted the footer to be mobile friendly. Cheers, Signed-off-by: kaimmej <[email protected]>
The footer legal notice was in the following pages: - tutorial - blog - events -faq -partners - versions Removed the footer_legal.html from the includes/ folder. Signed-off-by: kaimmej <[email protected]>
Signed-off-by: kaimmej <[email protected]>
…e row. This helps the template's content not spill into the footer element. Signed-off-by: kaimmej <[email protected]>
Signed-off-by: kaimmej <[email protected]>
Signed-off-by: kaimmej <[email protected]>
Also brought the social icons up into the footer, so there was not such a large gap. Renamed one of the footer nav categories - was: Brand Guidelines changed to: Brand & Trademark Signed-off-by: kaimmej <[email protected]>
Signed-off-by: Prudhvi Godithi <[email protected]>
Footer redesign
[2.16.0 Release] Update the calendar date for 2.16.0 retro meeting
krisfreedain
requested review from
elfisher,
AMoo-Miki,
nknize,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws,
nateynateynate and
natebower
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Footer redesign
[2.16.0 Release] Update the calendar date for 2.16.0 retro meeting
Issues Resolved
#3157
#3159
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.