Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logic of RCA conditional execution tag system #423

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented Jun 16, 2023

#308
Changed the locus tag system to support multiple values in the config files. Now when having a non dedicated cluster manager node, including that info inside the .conf file will allow for execution of RCA nodes with only cluster manager OR data node tags. Also with a dedicated cluster manager node, only the cluster manager tagged RCA nodes will be executed.
Changed this for HotShardRCA for now, should switch for all other analyses at some point.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #423 (33b02fc) into main (efa0fa0) will decrease coverage by 0.06%.
The diff coverage is 90.47%.

❗ Current head 33b02fc differs from pull request most recent head 62d479d. Consider uploading reports for the commit 62d479d to get more accurate results

@@             Coverage Diff              @@
##               main     #423      +/-   ##
============================================
- Coverage     75.98%   75.93%   -0.06%     
- Complexity     2581     2584       +3     
============================================
  Files           302      302              
  Lines         15356    15372      +16     
  Branches       1213     1215       +2     
============================================
+ Hits          11669    11672       +3     
- Misses         3193     3203      +10     
- Partials        494      497       +3     
Impacted Files Coverage Δ
...rg/opensearch/performanceanalyzer/rca/Version.java 0.00% <ø> (ø)
...nceanalyzer/rca/store/OpenSearchAnalysisGraph.java 100.00% <ø> (ø)
...erformanceanalyzer/rca/framework/util/RcaUtil.java 76.59% <89.47%> (+4.72%) ⬆️
...nsearch/performanceanalyzer/rca/RcaController.java 80.97% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant