refactor a constant and change the logging level for resource summary

Signed-off-by: Kaushal Kumar <[email protected]>
opensearch-project · Dec 21, 2023 · 3169f74 · 3169f74
1 parent e9b9585
commit 3169f74
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/org/opensearch/performanceanalyzer/LocalhostConnectionUtil.java b/src/main/java/org/opensearch/performanceanalyzer/LocalhostConnectionUtil.java
@@ -65,6 +65,8 @@ public static void disablePA() throws InterruptedException {
     public static class ClusterSettings {
         static List<String> clusterSettings = new ArrayList<>();
 
+        public final static String SETTING_NOT_FOUND = "NULL";
+
         static final String CLUSTER_SETTINGS_URL =
                 "/_cluster/settings?flat_settings=true&include_defaults=true&pretty";
 
@@ -111,7 +113,7 @@ public static String getClusterSettingValue(String settingName, String settingVa
                                         }
                                         return null;
                                     })
-                            .orElseGet(() -> "NULL");
+                            .orElseGet(() -> SETTING_NOT_FOUND);
             return settingVal;
         }
     }

diff --git a/...rformanceanalyzer/decisionmaker/deciders/searchbackpressure/SearchBackPressurePolicy.java b/...rformanceanalyzer/decisionmaker/deciders/searchbackpressure/SearchBackPressurePolicy.java
@@ -103,7 +103,7 @@ public SearchBackPressurePolicy(SearchBackPressureClusterRCA searchBackPressureC
      * @param issue an issue with the application
      */
     private void record(HotResourceSummary summary) {
-        LOG.debug("SearchBackPressurePolicy capturing resource summary: {}", summary);
+        LOG.trace("SearchBackPressurePolicy capturing resource summary: {}", summary);
 
         if (HEAP_SEARCHBP_SHARD_SIGNALS.contains(summary.getResource())) {
             LOG.debug("Shard signal in SBP RCA summary...");

diff --git a/...pensearch/performanceanalyzer/rca/store/rca/searchbackpressure/SearchBackPressureRCA.java b/...pensearch/performanceanalyzer/rca/store/rca/searchbackpressure/SearchBackPressureRCA.java
@@ -5,6 +5,7 @@
 
 package org.opensearch.performanceanalyzer.rca.store.rca.searchbackpressure;
 
+import static org.opensearch.performanceanalyzer.LocalhostConnectionUtil.ClusterSettings.SETTING_NOT_FOUND;
 import static org.opensearch.performanceanalyzer.rca.framework.api.persist.SQLParsingUtil.readDataFromSqlResult;
 import static org.opensearch.performanceanalyzer.rca.framework.api.summaries.ResourceUtil.SEARCHBACKPRESSURE_SHARD;
 import static org.opensearch.performanceanalyzer.rca.framework.api.summaries.ResourceUtil.SEARCHBACKPRESSURE_TASK;
@@ -199,7 +200,6 @@ private long getUpdatedHeapUsedIncreaseThreshold() {
                 LocalhostConnectionUtil.ClusterSettings.getClusterSettingValue(
                         SEARCH_BACKPRESSURE_HEAP_DURESS_KEY,
                         SEARCH_BACKPRESSURE_HEAP_DURESS_VAL_REGEX);
-        final String SETTING_NOT_FOUND = "NULL";
         // If there was an error fetching the threshold ignore for this run
         if (val.equals(SETTING_NOT_FOUND)) {
             LOG.warn("There was an error fetching the node duress heap settings value...");