Changes related to PA-RTF merge #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharvasharma61
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
atharvasharma61
changed the title
Signed-off-by: Atharva Sharma <[email protected]>
6 tasks
Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
Gaganjuneja
requested changes
Jun 5, 2024
src/main/java/org/opensearch/performanceanalyzer/commons/collectors/TelemetryCollector.java
Show resolved
Hide resolved
...org/opensearch/performanceanalyzer/commons/collectors/ScheduledMetricCollectorsExecutor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <[email protected]>
Signed-off-by: Atharva Sharma <[email protected]>
Gaganjuneja
previously approved these changes
Jun 5, 2024
Signed-off-by: Atharva Sharma <[email protected]>
nishchay21
reviewed
Jun 6, 2024
...org/opensearch/performanceanalyzer/commons/collectors/ScheduledMetricCollectorsExecutor.java
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <[email protected]>
nishchay21
approved these changes
Jun 8, 2024
Gaganjuneja
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Issue details to be added
Describe the solution you are proposing
Introducing support to read telemetry-collectors-enabled flag value from performance-analyzer.properties
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.