update log4j version to 2.21.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
requested review from
praveensameneni,
khushbr,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
getsaurabh02
approved these changes
Nov 16, 2023
| @@ -82,7 +82,7 @@ dependencies { | |||
| def jacksonVersion = "2.15.1" | |||
| def jacksonDataBindVersion = "2.14.1" | |||
| def junitVersion = "4.13.1" | |||
| def log4jVersion = "2.20.0" | |||
| def log4jVersion = "2.21.0" | |||
There was a problem hiding this comment.
Can we take dependency from core so as to avoid future version upgrades.
https://github.com/opensearch-project/performance-analyzer/blob/5ab3345ed8f9b076d5095cfa7248767a1fa35580/build.gradle#L272
There was a problem hiding this comment.
Hey @praveensameneni , yeah we should use dependency from core for all the above version numbers. But since this is a emergency change to unblock the 2.11 release today, let's make the change and revisit it later.
praveensameneni
approved these changes
Nov 16, 2023
kartva
pushed a commit
to kartva/performance-analyzer-commons
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Chenyang Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Update log4j version to 2.21.0
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.