Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mute collectors based on exception count #56

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: mute collectors based on exception count #56

wants to merge 13 commits into from

Commits on Nov 29, 2023

  1. count number of exceptions thrown by collectors 

    and use them in deciding whether to mute a collector
    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    63e9a85 View commit details
    Browse the repository at this point in the history

  2. remove unused aggregators in ServiceMetrics

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    bbbf261 View commit details
    Browse the repository at this point in the history

  3. wip

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d1d3db0 View commit details
    Browse the repository at this point in the history

  4. use old testing framework for now

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5db1e40 View commit details
    Browse the repository at this point in the history

  5. fix exceptioncount less than

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    68b697b View commit details
    Browse the repository at this point in the history

  6. fix java.lang.reflect.InaccessibleObjectException 

    caused by Mockito

ref: https://stackoverflow.com/questions/68113065/mockito-inaccessible-object-exception-while-creating-a-mock-object

To quote:
"This can happen if Mockito requires reflective access to non-public parts in a Java module.
you can get around this by explicitly allowing access via --add-opens in your java call"
    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    38a4857 View commit details
    Browse the repository at this point in the history

  7. remove debug prints

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e73e095 View commit details
    Browse the repository at this point in the history

  8. invokePrivileged should not catch exceptions 

    invokePrivilegedAndLogError already exists for that purpose

consider transitioning current uses to invokePrivilegedAndLogError

this is important as the exception counting mechanism relies on
exceptions not being swallowed earlier in call stack
    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ad7e4c8 View commit details
    Browse the repository at this point in the history

  9. improve TestCollector 

    by adding repetition options to runBehavior
    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b206a2a View commit details
    Browse the repository at this point in the history

  10. use mockito v2 api, make tests pass

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5f696e4 View commit details
    Browse the repository at this point in the history

  11. move uses of invokePrivileged to invokePrivilegedAndLogError

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7658b58 View commit details
    Browse the repository at this point in the history

  12. remove extra debug print

    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5c2193a View commit details
    Browse the repository at this point in the history

  13. revert removing unused collectors 

    will file separate PR
    @kartva
    kartva committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    45fbc21 View commit details
    Browse the repository at this point in the history