Working around OSB preload #992
Draft
+459
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ProcessLifecycleTest to use the base ES image and then upload documents onto the cluster before taking the snapshot. Passed tests locally, this can be reused for ParallelDocumentMigrationsTest if needed. - Created new package in RFS test fixtures org.opensearch.migrations.data that can generate any number of document needed following existing document conventions. This is pretty close to being a drop in replacement for the changes in ProcessLifecycleTest but more due dilligence should be done before jumping in. Signed-off-by: Peter Nied <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
============================================
+ Coverage 78.92% 78.94% +0.01%
- Complexity 2723 2724 +1
============================================
Files 374 374
Lines 13809 13809
Branches 970 970
============================================
+ Hits 10899 10901 +2
+ Misses 2336 2335 -1
+ Partials 574 573 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Testing
Ran
./gradlew DocumentsFromSnapshotMigration:slowTest --tests *testProcessExitsAsExpected*locallyCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.