Fix code smells in metadata commands #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
peternied
force-pushed
the
code-smell-metadata-commands
branch
from
cd22376
to
a16d11f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
============================================
+ Coverage 78.98% 79.00% +0.01%
- Complexity 2723 2724 +1
============================================
Files 375 375
Lines 13869 13869
Branches 970 970
============================================
+ Hits 10955 10957 +2
+ Misses 2340 2339 -1
+ Partials 574 573 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Rename this constant name to match the regular expression [...] - Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call. Signed-off-by: Peter Nied <[email protected]>
peternied
force-pushed
the
code-smell-metadata-commands
branch
from
a16d11f
to
569821d
Compare
gregschohn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix code smells in metadata commands
Issues Resolved
Check List
New functionality includes testingAll tests pass, including unit test, integration test and doctestNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.