Added docker pushing logs to cloudwatch functionality #50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
============================================
+ Coverage 76.69% 76.77% +0.08%
Complexity 179 179
============================================
Files 52 52
Lines 1124 1128 +4
Branches 49 49
============================================
+ Hits 862 866 +4
Misses 239 239
Partials 23 23 ☔ View full report in Codecov by Sentry. |
|
Thanks @bshien, if possible can we remove the special characters in the log next to INFO and DEBUG? |
| @@ -6,7 +6,7 @@ export interface SecretProps { | |||
| readonly secretName: string | |||
| } | |||
|
|
|||
| export class OpenSearchMetricsSecrets extends Stack { | |||
| export class OpenSearchMetricsSecretsStack extends Stack { | |||
There was a problem hiding this comment.
The OpenSearchMetricsSecrets should be fine here right ? as it already extends stack do we need OpenSearchMetricsSecretsStack?
There was a problem hiding this comment.
Since the other stacks have the Stack suffix, I thought it would be better to keep that style
There was a problem hiding this comment.
does this name change destroy the stack and recreate ?
There was a problem hiding this comment.
Tested on local, it didn't destroy the stack, I think that only happens if the id changes
Having a log formatter to |
Signed-off-by: Brandon Shien <[email protected]>
|
Merging this as there is some issue with mend and not related to this code change. |
Description
Logs look like this in Cloudwatch:
Issues Resolved
#47
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.