Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Add release workflows #84

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add release workflows #84

merged 1 commit into from
Feb 16, 2023

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Nov 18, 2022 •
edited
Loading

Signed-off-by: Sayali Gaikawad [email protected]

Description

This PR adds below things:

  • A GitHub action workflow that will be triggered when a tag is pushed to this repository. The workflow builds the product and creates a draft release with built artifacts attached as artifacts.tar.gz in the release.
  • A jenkins workflow that is triggered based on above draft release. The workflow looks for artifacts.tar.gz, downloads it and then signs it and publishes it to PyPi

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass.
  • New functionality has been documented.
    • New functionality has comments added.
  • Commits are signed per the DCO using --signoff.
  • CHANGELOG has been updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following the Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya gaiksaya requested review from a team and Yury-Fridlyand as code owners November 18, 2022 21:46
@gaiksaya
Copy link
Member Author

Getting few things in place so please wait before merging. Please feel free to review till then.
Thanks!

@VachaShah
Copy link
Collaborator

Workflows are failing for certain python versions for the latest ubuntu-22.04. Related issue on actions/setup-python actions/setup-python#543

@gaiksaya
Copy link
Member Author

Hi @VachaShah ,

I specified the ubuntu-latest version explicitly in the above failing workflows. Looks like GH is changing its GH runners for ubuntu latest from 20 to 22.
Let me know if this works. For link-checker, once this PR is approved, I'll add the workflow so that, that workflow passes too.
Thanks!

@gaiksaya
Copy link
Member Author

Everything is set up. Once this PR is merged, I'll be creating the webhooks that will trigger the release when a tag is pushed.
Please review.
Thanks!

VachaShah
VachaShah reviewed Jan 19, 2023
View reviewed changes
RELEASING.md Outdated

1. Create a tag, e.g. v2.1.0, and push it to the GitHub repo.
1. The [release-drafter.yml](.github/workflows/release-drafter.yml) will be automatically kicked off and a draft release will be created.
1. This draft release triggers the [jenkins release workflow](https://build.ci.opensearch.org/job/opensearch-dsl-py-release/) as a result of which opensearch-py client is released on [PyPi](https://pypi.org/project/opensearch-dsl/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a result of which opensearch-dsl-py client is released...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@VachaShah VachaShah closed this Jan 19, 2023
@VachaShah VachaShah reopened this Jan 19, 2023
@VachaShah
Copy link
Collaborator

Sorry closed this by mistake. @gaiksaya Added a comment

@VachaShah VachaShah mentioned this pull request Jan 19, 2023
Merged
6 tasks
Yury-Fridlyand
Yury-Fridlyand reviewed Jan 20, 2023
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -56,7 +56,7 @@ jobs:
python3.7 -m build

test-linux:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest is 22.04 now, so this change is a downgrade.
I made a fix for CI workflow in #92.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased with main.

@gaiksaya
Add release workflows
b75aa90 
Signed-off-by: Sayali Gaikawad <[email protected]>
@VachaShah VachaShah merged commit 2b9e688 into opensearch-project:main Feb 16, 2023
@gaiksaya gaiksaya deleted the release-worklows branch February 16, 2023 18:45
@gaiksaya
Copy link
Member Author

The webhook has been added. We should be good for the release.

@VachaShah VachaShah mentioned this pull request Feb 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@harshavamsi harshavamsi harshavamsi approved these changes

@VachaShah VachaShah VachaShah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaiksaya @VachaShah @harshavamsi @Yury-Fridlyand