-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSearch Dashboards Helm Chart #10
OpenSearch Dashboards Helm Chart #10
Conversation
Signed-off-by: Dhiraj Jain <[email protected]>
Signed-off-by: Dhiraj Jain <[email protected]>
Signed-off-by: Dhiraj Jain <[email protected]>
Thanks @TheAlgo for this new PR. Hi @DandyDeveloper would love your opinion and review on this one as well. Also #4 has been merged now. |
Should this live in its own repo? |
Lets get it review and merged before we decide that. |
I'll take a look in a day or so. |
Signed-off-by: Dhiraj Jain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid but I have a number of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you don't mind me jumping in to review this. I'm excited for this chart to become available!
Signed-off-by: Dhiraj Jain <[email protected]>
Signed-off-by: Dhiraj Jain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheAlgo Sorry, I just went over this one more time post your changes, there's some super minor items but nothing major.
It'd be good to discuss these but they don't break the chart in its current form.
Signed-off-by: Dhiraj Jain <[email protected]>
@DandyDeveloper @smlx @davidkarlsen I have addressed and replied on all the comments. It will be great if you all can review it one more time. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No further issues for now. Looks good.
I suspect more edge cases will come up, but hopefully people communicate those to us.
Test on EKS:
|
Thanks Everyone in the work to get this PR merged, we are officially ready for community to consume both OpenSearch and Dashboards in Helm. |
Signed-off-by: Dhiraj Jain [email protected]
Description
Create Helm Chart for OpenSearch Dashboards. It is an easy way to run the official docker image.
Future Plans
Issues Resolved
#5
#2
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.