Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch Dashboards Helm Chart #10

Merged
merged 9 commits into from
Aug 5, 2021

Conversation

TheAlgo
Copy link
Member

@TheAlgo TheAlgo commented Jul 12, 2021

Signed-off-by: Dhiraj Jain [email protected]

Description

Create Helm Chart for OpenSearch Dashboards. It is an easy way to run the official docker image.

Future Plans

  1. Add exhaustive README.md
  2. Host the chart in github
  3. Provide a helm chart for OpenSearch so that this chart can be easily be deployed along with OpenSearch chart,

Issues Resolved

#5
#2

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TheAlgo TheAlgo marked this pull request as ready for review July 15, 2021 16:45
@peterzhuamazon
Copy link
Member

Thanks @TheAlgo for this new PR.

Hi @DandyDeveloper would love your opinion and review on this one as well.

Also #4 has been merged now.

@dblock
Copy link
Member

dblock commented Jul 22, 2021

Should this live in its own repo?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jul 22, 2021

Should this live in its own repo?

Lets get it review and merged before we decide that.
Meanwhile we can discuss in the issue: #11

@DandyDeveloper
Copy link
Collaborator

I'll take a look in a day or so.

Copy link
Collaborator

@DandyDeveloper DandyDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid but I have a number of comments.

Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Show resolved Hide resolved
Helm/opensearch-dashboards/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind me jumping in to review this. I'm excited for this chart to become available!

Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/configmap.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/configmap.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/role.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
Helm/opensearch-dashboards/templates/deployment.yaml Outdated Show resolved Hide resolved
@peterzhuamazon peterzhuamazon mentioned this pull request Jul 29, 2021
1 task
Signed-off-by: Dhiraj Jain <[email protected]>
Signed-off-by: Dhiraj Jain <[email protected]>
Copy link
Collaborator

@DandyDeveloper DandyDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheAlgo Sorry, I just went over this one more time post your changes, there's some super minor items but nothing major.

It'd be good to discuss these but they don't break the chart in its current form.

@TheAlgo
Copy link
Member Author

TheAlgo commented Aug 4, 2021

@DandyDeveloper @smlx @davidkarlsen I have addressed and replied on all the comments. It will be great if you all can review it one more time. Thanks

Copy link
Collaborator

@DandyDeveloper DandyDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further issues for now. Looks good.

I suspect more edge cases will come up, but hopefully people communicate those to us.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Aug 5, 2021

Test on EKS:

$ helm install --generate-name opensearch-dashboards-1.0.0.tgz
NAME: opensearch-dashboards-1-1628184109
LAST DEPLOYED: Thu Aug  5 13:21:55 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace default -l "app.kubernetes.io/name=opensearch-dashboards,app.kubernetes.io/instance=opensearch-dashboards-1-1628184109" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace default $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl --namespace default port-forward $POD_NAME 8080:$CONTAINER_PORT
$ helm install --generate-name opensearch-1.0.0.tgz
NAME: opensearch-1-1628184200
LAST DEPLOYED: Thu Aug  5 13:23:25 2021
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Watch all cluster members come up.
  $ kubectl get pods --namespace=default -l app=opensearch-cluster-master -w
$ kubectl get pods
NAME                                                  READY   STATUS    RESTARTS   AGE
opensearch-cluster-master-0                           1/1     Running   0          3m56s
opensearch-cluster-master-1                           1/1     Running   0          3m56s
opensearch-cluster-master-2                           1/1     Running   0          3m56s
opensearch-dashboards-1-1628184109-584ff47c54-gghf2   1/1     Running   0          5m25s
$  kubectl exec -it opensearch-dashboards-1-1628184109-584ff47c54-gghf2 -- /bin/bash
[opensearch-dashboards@opensearch-dashboards-1-1628184109-584ff47c54-gghf2 ~]$ netstat -ntlp
bash: netstat: command not found
[opensearch-dashboards@opensearch-dashboards-1-1628184109-584ff47c54-gghf2 ~]$ ss
bash: ss: command not found
[opensearch-dashboards@opensearch-dashboards-1-1628184109-584ff47c54-gghf2 ~]$ curl localhost:9200
curl: (7) Failed to connect to localhost port 9200: Connection refused
[opensearch-dashboards@opensearch-dashboards-1-1628184109-584ff47c54-gghf2 ~]$ curl localhost:5601
[opensearch-dashboards@opensearch-dashboards-1-1628184109-584ff47c54-gghf2 ~]$ curl localhost:5601/api/status
{"name":"opensearch-dashboards-1-1628184109-584ff47c54-gghf2","uuid":"1daa4ed6-0453-4d2a-b334-27b7f92f181b","version":{"number":"1.0.0","build_hash":"b15ad258e6960003e609a70889cda5fb39f90947","build_number":36473,"build_snapshot":false},"status":{"overall":{"since":"2021-08-05T17:30:54.274Z","state":"green","title":"Green","nickname":"Looking good","icon":"success","uiColor":"secondary"},"statuses":[{"id":"core:[email protected]","message":"OpenSearch is available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"core:[email protected]","message":"SavedObjects service has completed migrations and is available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:5
4.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"},{"id":"plugin:[email protected]","message":"All dependencies are available","since":"2021-08-05T17:30:54.274Z","state":"green","icon":"success","uiColor":"secondary"}]},"metrics":{"last_updated":"2021-08-05T17:30:53.048Z","collection_interval_in_millis":5000,"os":{"platform":"linux","platformRelease":"linux-4.14.238-182.422.amzn2.x86_64","load":{"1m":0.06494140625,"5m":0.185546875,"15m":0.1494140625},"memory":{"total_in_bytes":16509009920,"free_in_bytes":8975130624,"used_in_bytes":7533879296},"uptime_in_millis":2276000,"distro":"Amazon Linux","distroRelease":"Amazon Linux-2 (Karoo)","cpuacct":{"control_group":"/","usage_nanos":6572383820},"cpu":{"control_group":"/","cfs_period_micros":100000,"cfs_quota_micros":10000,"stat":{"number_of_elapsed_periods":1141,"number_of_times_throttled":545,"time_throttled_nanos":80396083442}}},"process":{"memory":{"heap":{"total_in_bytes":104669184,"used_in_bytes":91412248,"size_limit":1526909922},"resident_set_size_in_bytes":141987840},"pid":1,"event_loop_delay":0.4016510001383722,"uptime_in_millis":492354},"response_times":{"avg_in_millis":116,"max_in_millis":116},"concurrent_connections":0,"requests":{"disconnects":0,"total":1,"statusCodes":{"302":1},"status_codes":{"302":1}}}}

@peterzhuamazon
Copy link
Member

Thanks Everyone in the work to get this PR merged, we are officially ready for community to consume both OpenSearch and Dashboards in Helm.

@peterzhuamazon peterzhuamazon merged commit 0b2b490 into opensearch-project:main Aug 5, 2021
@TheAlgo TheAlgo deleted the dashboards-helm branch August 5, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants