Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Stabilize split.spec.js #699 #798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Table] Stabilize split.spec.js #699 #798

wants to merge 2 commits into from

Conversation

arpitjaswal
Copy link

Description

This pull request updates the test commands and React component as follows:

  • Refactors test commands to use modified data test subjects for improved stability and readability.
  • Incorporates custom command functions for enhanced testing capabilities.

In the React component:

  • Replaced instances of EuiFlexItem that were declared but not used.
  • Updated data test subjects for the visualization groups to improve test selectivity.

These changes enhance the test suite by improving its stability, readability, and coverage.

Issues Resolved

This PR resolves issue #699

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavilla kavilla linked an issue Sep 5, 2023 that may be closed by this pull request
[Table] Stabilize split.spec.js #699
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@ruanyl ruanyl ruanyl approved these changes

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] Stabilize split.spec.js
4 participants
@arpitjaswal @ruanyl @kavilla @SuZhou-Joe