select checkbox via id instead of class name #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nishant Goel <[email protected]>
nisgoel-amazon
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
74 tasks
RamakrishnaChilaka
approved these changes
Aug 5, 2024
getsaurabh02
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Lint Checker is failing with some errors, can we please fix that: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/10250963563/job/28357892973?pr=1503
getsaurabh02
approved these changes
Aug 5, 2024
CaptainDredge
approved these changes
Aug 5, 2024
Signed-off-by: Nishant Goel <[email protected]>
will be fixed by #1505 |
… text Signed-off-by: Nishant Goel <[email protected]>
prudhvigodithi
approved these changes
Aug 5, 2024
|
Index Management Release tests workflow in Bundled OpenSearch Dashboards / tests / Run Cypress E2E tests for Index Management (pull_request) |
prudhvigodithi
merged commit 77b4d19
into
opensearch-project:main
38 of 39 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
* select checkbox via id instead of class name Signed-off-by: Nishant Goel <[email protected]> * Re trigger PR workflows Signed-off-by: Nishant Goel <[email protected]> * Instead of sorting in asc order on aliases page, search the alias via text Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 77b4d19)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
* select checkbox via id instead of class name Signed-off-by: Nishant Goel <[email protected]> * Re trigger PR workflows Signed-off-by: Nishant Goel <[email protected]> * Instead of sorting in asc order on aliases page, search the alias via text Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 77b4d19)
prudhvigodithi
pushed a commit
that referenced
this pull request
Aug 5, 2024
* select checkbox via id instead of class name Signed-off-by: Nishant Goel <[email protected]> * Re trigger PR workflows Signed-off-by: Nishant Goel <[email protected]> * Instead of sorting in asc order on aliases page, search the alias via text Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 77b4d19) Co-authored-by: Nishant Goel <[email protected]>
prudhvigodithi
pushed a commit
that referenced
this pull request
Aug 5, 2024
* select checkbox via id instead of class name Signed-off-by: Nishant Goel <[email protected]> * Re trigger PR workflows Signed-off-by: Nishant Goel <[email protected]> * Instead of sorting in asc order on aliases page, search the alias via text Signed-off-by: Nishant Goel <[email protected]> --------- Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit 77b4d19) Co-authored-by: Nishant Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is flaky test where checkbox is not getting selected in windows run.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.