[MDS]Add FT for Import saved objects #1349
Conversation
yujin-emma
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao and
zhongnansu
as code owners
| cy.contains('new').should('be.visible'); | ||
| } else { | ||
| if (override !== 'overwriteEnabled') { | ||
| for (let i = 0; i < 29; i++) { |
There was a problem hiding this comment.
Nit: I assume 29 is the number of conflicting saved objects. Could this be extracted into a variable like numConflictingSavedObjects?
There was a problem hiding this comment.
This is the length of the test file length, good suggestion if we consider always using this as the test file
...ess/fixtures/dashboard/opensearch_dashboards/saved_objects_management/mds_log_objects.ndjson
Outdated
Show resolved
Hide resolved
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| Cypress.Commands.add('selectDataSourceForImport', (dataSourceTitle) => { |
There was a problem hiding this comment.
can we reuse existing util to select data source from data source selector?
There was a problem hiding this comment.
sorry, I tried this one, but I found the selector on import page does not have the input, while the dev tools has this functionality, if reusing, it can break
There was a problem hiding this comment.
I see, let's use your util for import then. Great finding, let me file an issue on OSD to make "isClearable" prop consistent across all places that consumes this selector in OSD
|
@yujin-emma CI failed to run, seems we need to update the package-lock.json file to include in this PR, since you added a new dependency. https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/9408260167/job/25915840497?pr=1349 |
Signed-off-by: yujin-emma <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]>
|
CI is failing for the saved object test you added. Could you check? @yujin-emma |
Description
Add test to import MDS exported saved objects to MDS DS
Issues Resolved
06_06_01_mds_import_test.spec.js.mp4
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.