[Workspace] Add functional test for workspace overview page #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Hailong-am
changed the title
SuZhou-Joe
force-pushed
the
workspace_overview
branch
from
2666392
to
0d8080a
Compare
SuZhou-Joe
reviewed
Apr 29, 2024
SuZhou-Joe
reviewed
Apr 29, 2024
| @@ -42,7 +42,9 @@ if (Cypress.env('WORKSPACE_ENABLED')) { | |||
| 'workspaceForm-workspaceFeatureVisibility-OpenSearch Dashboards' | |||
| ).check({ force: true }); | |||
| cy.get('[id$="discover"]').uncheck({ force: true }); | |||
| cy.getElementByTestId('workspaceForm-bottomBar-createButton').click(); | |||
| cy.getElementByTestId('workspaceForm-bottomBar-createButton').click({ | |||
There was a problem hiding this comment.
Nit: just curious why we need to add force: true, is it being covered by other elements?
There was a problem hiding this comment.
covered by
when doing test in local
There was a problem hiding this comment.
Seems the root cause of this toast is CSP restriction. Could we create a separate issue and add related config like OSD cypress workflow?
There was a problem hiding this comment.
create a issue #1252 to track this.
Hailong-am
force-pushed
the
workspace_overview
branch
from
3477dd0
to
081491a
Compare
wanglam
reviewed
Apr 29, 2024
wanglam
reviewed
Apr 29, 2024
...core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/workspace_overview.spec.js
Outdated
Show resolved
Hide resolved
wanglam
reviewed
Apr 29, 2024
...core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/workspace_overview.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
workspace_overview
branch
from
081491a
to
4c041fa
Compare
Signed-off-by: Hailong Cui <[email protected]>
wanglam
reviewed
Apr 30, 2024
Signed-off-by: Hailong Cui <[email protected]>
raintygao
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
* workspace overview Signed-off-by: Hailong Cui <[email protected]> * update create workspace Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * Add assertion Signed-off-by: Hailong Cui <[email protected]> * fix workspacd name Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 1b19f50)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 30, 2024
…1255) * workspace overview Signed-off-by: Hailong Cui <[email protected]> * update create workspace Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * Add assertion Signed-off-by: Hailong Cui <[email protected]> * fix workspacd name Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 1b19f50) Co-authored-by: Hailong Cui <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ch-project#1246) * workspace overview Signed-off-by: Hailong Cui <[email protected]> * update create workspace Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> * Add assertion Signed-off-by: Hailong Cui <[email protected]> * fix workspacd name Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functional test for workspace overview page
Issues Resolved
opensearch-project/OpenSearch-Dashboards#6583
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.