Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS18 Upgrade] Remove old AL2 Docker Host and Tweak Windows Startup Scripts #342

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 6, 2023

Description

[NodeJS18 Upgrade] Remove old AL2 Docker Host and Tweak Windows Startup Scripts

Issues Resolved

opensearch-project/opensearch-build#1563
opensearch-project/opensearch-build#3743

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaiksaya
Copy link
Member

gaiksaya commented Sep 6, 2023

Please do not remove host. They can be used by multiple projects outside opensearch-build scope. Jenkins-Agent-AL2-X64-C54xlarge-Docker-Host is atleast vastly in use for now. We can add new ones but old ones should not be removed prior to heads-up or warning for atleast few months.
Thanks!

@peterzhuamazon
Copy link
Member Author

Please do not remove host. They can be used by multiple projects outside opensearch-build scope. Jenkins-Agent-AL2-X64-C54xlarge-Docker-Host is atleast vastly in use for now. We can add new ones but old ones should not be removed prior to heads-up or warning for atleast few months. Thanks!

I didnt realize they are still being used by clients.
I am ok to restore them but we still need to remove them at some time.

Thanks.

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon peterzhuamazon merged commit adfb346 into opensearch-project:main Sep 6, 2023
3 checks passed
@peterzhuamazon peterzhuamazon deleted the al2023-nodejs18-jenkins-amis branch September 6, 2023 20:21
@peterzhuamazon
Copy link
Member Author

peterzhuamazon added a commit to peterzhuamazon/opensearch-ci that referenced this pull request Sep 6, 2023
peterzhuamazon added a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants