Automate adding manifest to integTest notification cron #5098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
dblock,
peterzhuamazon,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
| if cron_entry in data: | ||
| raise ValueError(f"{integTestJenkinsfile} already contains an entry for {self.prefix} {version}") | ||
|
|
||
| data = data.replace("parameterizedCron('''\n", f"parameterizedCron('''\n{' ' * 12}{cron_entry}") |
There was a problem hiding this comment.
Parenthesis wrong?
See above example
data = data.replace("parameterizedCron '''\n", f"parameterizedCron '''\n{' ' * 12}{cron_entry}")
There was a problem hiding this comment.
Its different for both files. Both are correct. Let me know if you have a preference.
Has been working well https://build.ci.opensearch.org/view/Test/job/integ-test-notification/
There was a problem hiding this comment.
I see what you mean now.
No issues then.
peterzhuamazon
approved these changes
Oct 11, 2024
| if cron_entry in data: | ||
| raise ValueError(f"{integTestJenkinsfile} already contains an entry for {self.prefix} {version}") | ||
|
|
||
| data = data.replace("parameterizedCron('''\n", f"parameterizedCron('''\n{' ' * 12}{cron_entry}") |
There was a problem hiding this comment.
I see what you mean now.
No issues then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automate adding manifest to integTest notification jenkinsfile cronjob
Issues Resolved
closes #5083
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.