Add new stage in gradle-check to check and abort stale runs #5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <[email protected]>
rishabh6788
requested review from
dblock,
peterzhuamazon,
gaiksaya,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
|
@peterzhuamazon Please provide your feedback and review. |
gaiksaya
reviewed
Sep 19, 2024
gaiksaya
approved these changes
Sep 19, 2024
peterzhuamazon
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
I agree that if a PR author push a new commit, they would most likely want to see the result of the new commit, not old commit, thus we can start with this change, and monitor the outcome of it.
Thanks @rishabh6788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new stage in gradle-check to check and abort previous in-progress runs for the same pull-request.
Issues Resolved
#5008
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.