Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rpm-validation jenkins job in build repo #5040

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Divyaasm
Copy link
Collaborator

Description

rpm-validation is now completely migrated to Validation Workflow.

Cleaning up the job and it's usage in the distribution-build workflows.

Issues Resolved

#4968

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.46%. Comparing base (5372fbb) to head (97615c2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5040   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         197      197           
  Lines        6727     6727           
=======================================
  Hits         6220     6220           
  Misses        507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing jenkins/rpm-validation/rpm-validation.jenkinsfile just put it into legacy dir like others.

@gaiksaya
Copy link
Member

gaiksaya commented Sep 19, 2024

Instead of removing jenkins/rpm-validation/rpm-validation.jenkinsfile just put it into legacy dir like others.

I dont believe we have legacy for jenksinfiles, We can retrieve it anytime we want from old branches/tags.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 19, 2024

Instead of removing jenkins/rpm-validation/rpm-validation.jenkinsfile just put it into legacy dir like others.

I dont believe we have legacy for jenksinfiles, We can retrieve it anytime we want from old branches/tags.

We have legacy for docker files and others tho.

@gaiksaya
Copy link
Member

gaiksaya commented Sep 19, 2024

Looks like we do have https://github.com/opensearch-project/opensearch-build/tree/main/jenkins/legacy
I feel its irrelevant but upon you if you want to keep it. Same goes for other legacy files. They wont ever be used and we can get if we want from tags or branches.

@peterzhuamazon
Copy link
Member

Looks like we do have https://github.com/opensearch-project/opensearch-build/tree/main/jenkins/legacy I feel its irrelevant but upon you if you want to keep it. Same goes for other legacy files. They wont ever be used and we can get if we want from tags or branches.

I would say keep it and it is easier for users to check.

Hi @Divyaasm would you mind move it to legacy dir?

Thanks.

@Divyaasm Divyaasm merged commit 33a61f3 into opensearch-project:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants