-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove rpm-validation jenkins job in build repo #5040
Conversation
Signed-off-by: Divya Madala <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5040 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 197 197
Lines 6727 6727
=======================================
Hits 6220 6220
Misses 507 507 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing jenkins/rpm-validation/rpm-validation.jenkinsfile
just put it into legacy dir like others.
I dont believe we have legacy for jenksinfiles, We can retrieve it anytime we want from old branches/tags. |
We have legacy for docker files and others tho. |
Looks like we do have https://github.com/opensearch-project/opensearch-build/tree/main/jenkins/legacy |
I would say keep it and it is easier for users to check. Hi @Divyaasm would you mind move it to legacy dir? Thanks. |
Signed-off-by: Divya Madala <[email protected]>
Description
rpm-validation is now completely migrated to Validation Workflow.
Cleaning up the job and it's usage in the distribution-build workflows.
Issues Resolved
#4968
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.