Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs and entrypoint for logging.ignoreEnospcError in 2.15.0 #4695

Merged

Conversation

Flyingliuhub
Copy link
Member

Description

Update configs and entrypoint for logging.ignoreEnospcError in 2.15.0

Issues Resolved

opensearch-project/OpenSearch-Dashboards#6733

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Flyingliuhub <[email protected]>
@prudhvigodithi
Copy link
Collaborator

Should this be on hold until 2.14.0 is out or until the RC is finalized ?
@peterzhuamazon @rishabh6788.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Flyingliuhub ,

Block this until 2.14.0 version is out.

Thanks.

@prudhvigodithi prudhvigodithi self-requested a review May 14, 2024 16:11
@Flyingliuhub
Copy link
Member Author

@peterzhuamazon as

Thanks @Flyingliuhub ,

Block this until 2.14.0 version is out.

Thanks.

@peterzhuamazon 2.14.0 is already out. Can you please help review? Thanks

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 16, 2024

Hi @Flyingliuhub , could you add the corresponding config change PR from OSD in PR comments?

Thanks.

@Flyingliuhub
Copy link
Member Author

Hi @Flyingliuhub , could you add the corresponding config change PR from OSD in PR comments?

Thanks.

I already mentioned the in the PR comments above for Issues Resolved section. did you have a chance to click the link?

@peterzhuamazon
Copy link
Member

Hi @Flyingliuhub , could you add the corresponding config change PR from OSD in PR comments?
Thanks.

I already mentioned the in the PR comments above for Issues Resolved section. did you have a chance to click the link?

Missed that, thanks for pointing out.
We will hold this PR for a bit longer in case 2.14.1 is on the way.
Thanks.

@peterzhuamazon
Copy link
Member

We are ready to merge for #4681 .

@peterzhuamazon peterzhuamazon merged commit 64a556f into opensearch-project:main Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants