Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single version loose param for building plugins #4468

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Add single version loose param for building plugins #4468

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64400f5
Add single version loose param
derek-ho Feb 21, 2024
14e0aac
Add parameter for version inc workflow
derek-ho Feb 27, 2024
04a994e
Add loose parameter to else block bootstrap
derek-ho Feb 28, 2024
08195e2
Remove loose in default build
derek-ho Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/osd-increment-plugin-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
run: |
cd OpenSearch-Dashboards/plugins/${{ matrix.entry.repo }}
if [ ${{ matrix.entry.path }} ]; then
yarn osd bootstrap
yarn osd bootstrap --single-version=loose
cp -R ${{ matrix.entry.path }} ../
cd ../${{ matrix.entry.path }}
node ../../scripts/plugin_helpers version --sync legacy
Expand All @@ -101,7 +101,7 @@ jobs:
OSD_PLUGIN_VERSION=$(node -p "require('./package.json').version")
echo "OSD_PLUGIN_VERSION=$OSD_PLUGIN_VERSION" >> $GITHUB_ENV
else
yarn osd bootstrap
yarn osd bootstrap --single-version=loose
node ../../scripts/plugin_helpers version --sync legacy
OSD_PLUGIN_VERSION=$(node -p "require('./package.json').version")
echo "OSD_PLUGIN_VERSION=$OSD_PLUGIN_VERSION" >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion scripts/default/opensearch-dashboards/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ mkdir -p $OUTPUT/plugins
cp -r ../$PLUGIN_NAME/ ../OpenSearch-Dashboards/plugins
echo "BUILD MODULES FOR $PLUGIN_NAME"
CURR_DIR=`pwd`
cd ../OpenSearch-Dashboards; eval $NVM_CMD; yarn osd bootstrap
cd ../OpenSearch-Dashboards; eval $NVM_CMD; yarn osd bootstrap --single-version=loose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not fully applicable due to this will affect 1.x.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhuamazon what do you suggest here, should we add a version check here to make sure we only run this above a specific version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhuamazon Any idea how to proceed here? Looks like many plugins are failing for 2.13.0 because of this.

echo "BUILD RELEASE ZIP FOR $PLUGIN_NAME"
cd plugins/$PLUGIN_NAME; yarn $HELPER_STRING build --opensearch-dashboards-version=$VERSION$QUALIFIER_IDENTIFIER
cd $CURR_DIR
Expand Down
Loading