Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OPENSEARCH_DASHBOARDS_HOME args works correctly in dashboards dockerfile #4327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make OPENSEARCH_DASHBOARDS_HOME args works correctly in dashboards dockerfile #4327

wants to merge 1 commit into from

Conversation

donggyu04
Copy link

Description

  1. Fix wrong comment.
  2. Make OPENSEARCH_DASHBOARDS_HOME argument works correctly.

donggyu04
donggyu04 commented Jan 5, 2024
View reviewed changes
docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint-1.x.sh
@@ -176,7 +173,7 @@ function setupSecurityDashboardsPlugin {
function runOpensearchDashboards {
longopts=()
for opensearch_dashboards_var in ${opensearch_dashboards_vars[*]}; do
# 'opensearch.hosts' -> 'OPENSEARCH_URL'
# 'opensearch.hosts' -> 'OPENSEARCH_HOSTS'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opensearch.hosts is converted to OPENSEARCH_HOSTS. OPENSEARCH_URL is not correct.

donggyu04
donggyu04 commented Jan 5, 2024
View reviewed changes
docker/release/config/opensearch-dashboards/opensearch-dashboards-docker-entrypoint-1.x.sh
@@ -15,9 +15,6 @@
#
# --opensearch.startupTimeout=60

# Setup Home Directory
export OPENSEARCH_DASHBOARDS_HOME=/usr/share/opensearch-dashboards
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this depends on ARG OPENSEARCH_DASHBOARDS_HOME in Dockerfile. so I added this to ENV at Dockerfile

@donggyu04 donggyu04 force-pushed the make-dashboards-home-works-correctly-in-dockerfile branch from 619f0a0 to 5d75316 Compare March 26, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@bbarani bbarani Awaiting requested review from bbarani

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

@rishabh6788 rishabh6788 Awaiting requested review from rishabh6788 rishabh6788 is a code owner

@zelinh zelinh Awaiting requested review from zelinh zelinh is a code owner

@jordarlu jordarlu Awaiting requested review from jordarlu

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@Divyaasm Divyaasm Awaiting requested review from Divyaasm Divyaasm is a code owner

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
first-time-contributor
Projects
Engineering Effectiveness Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@donggyu04