Removed hybrid search feature flag for test clusters #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
|
@peterzhuamazon please check, this change will revert #3927 |
Codecov Report
@@ Coverage Diff @@
## main #3957 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 187 187
Lines 5669 5669
=======================================
Hits 5219 5219
Misses 450 450 |
71 tasks
|
Wait for this: |
peterzhuamazon
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove feature flag for hybrid_search from neural-search plugin. Feature flag meaning and name has been changed (opensearch-project/neural-search#275), with existing code cluster may crush on start as feature flag doesn't exit.
This PR will revert earlier change, that change is not needed, feature is enabled by default.
Issues Resolved
#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.