Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch Release Process: Fix wrong links. #3855

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

prudhvigodithi
Copy link
Collaborator

Description

OpenSearch Release Process: Fix wrong links.

Issues Resolved

Coming from #3635

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Member

gaiksaya commented Aug 7, 2023

Looks like this workflow is not getting triggerd: https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/link-checker.yml

@prudhvigodithi Can you fix that too? Add main under push

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #3855 (7424678) into main (89cec67) will increase coverage by 0.24%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3855      +/-   ##
==========================================
+ Coverage   91.62%   91.86%   +0.24%     
==========================================
  Files         186      186              
  Lines        5633     5633              
==========================================
+ Hits         5161     5175      +14     
+ Misses        472      458      -14     

see 2 files with indirect coverage changes

@prudhvigodithi
Copy link
Collaborator Author

Looks like this workflow is not getting triggerd: https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/link-checker.yml

@prudhvigodithi Can you fix that too? Add main under push

It already has on: push:, let me see why its not getting triggered.

Signed-off-by: Prudhvi Godithi <[email protected]>
@prudhvigodithi
Copy link
Collaborator Author

Works now @gaiksaya, please check.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the link checker too.

@prudhvigodithi prudhvigodithi merged commit 286bbb7 into opensearch-project:main Aug 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants