Make docker command detection consistently across OSes #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
Signed-off-by: Peter Zhu <[email protected]>
rishabh6788
reviewed
Jul 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
=========================================
Coverage 86.63% 86.63%
Complexity 27 27
=========================================
Files 77 77
Lines 202 202
Branches 11 11
=========================================
Hits 175 175
Misses 19 19
Partials 8 8 |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
rishabh6788
approved these changes
Jul 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit 5b00d67) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make docker command detection consistently across OSes
Issues Resolved
opensearch-project/opensearch-build#3816
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.