Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker login for both source and dest registries #249

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 19, 2023

Description

Add docker login for both source and dest registries

Issues Resolved

opensearch-project/opensearch-build#3737
opensearch-project/opensearch-build#3616

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the bug Something isn't working label Jul 19, 2023
@peterzhuamazon peterzhuamazon self-assigned this Jul 19, 2023
@peterzhuamazon peterzhuamazon added enhancement New feature or request backport 5.x labels Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #249 (cdb6c12) into main (de8ea90) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #249   +/-   ##
=========================================
  Coverage     86.63%   86.63%           
  Complexity       27       27           
=========================================
  Files            77       77           
  Lines           202      202           
  Branches         11       11           
=========================================
  Hits            175      175           
  Misses           19       19           
  Partials          8        8           

@peterzhuamazon peterzhuamazon merged commit 8776b89 into opensearch-project:main Jul 19, 2023
10 checks passed
@peterzhuamazon peterzhuamazon deleted the docker-copy-login branch July 19, 2023 21:41
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2023
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 8776b89)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Member Author

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 5.x bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants