Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix matchAllQuery #572

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

amberzsy
Copy link
Contributor

@amberzsy amberzsy commented Sep 12, 2024

Description

curr def:

MatchAllQuery:
      allOf:
        - $ref: '#/components/schemas/QueryBase'
        - type: object

extra free-format object in match all query

image

image

we can fix with

MatchAllQuery:
      allOf:
        - $ref: '#/components/schemas/QueryBase'

or

MatchAllQuery:
        - $ref: '#/components/schemas/QueryBase'

Issues Resolved

#571

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: amberzsy <[email protected]>
Copy link

Changes Analysis

Commit SHA: ed8e518
Comparing To SHA: 508c210

API Changes

Summary

└─┬Components
  └─┬_common.query_dsl:MatchAllQuery
    └──[🔀] $ref (38046:13)❌ 

Document Element Total Changes Breaking Changes
components 1 1
  • BREAKING Changes: 1 out of 1
  • Modifications: 1
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10824196271/artifacts/1925573721

API Coverage

Before After Δ
Covered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Uncovered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Unknown 26 26 0

Copy link

Spec Test Coverage Analysis

Total Tested
571 282 (49.39 %)

@nhtruong nhtruong added the skip-changelog No need to update CHANGELOG. label Sep 12, 2024
@nhtruong nhtruong merged commit 97cfa9b into opensearch-project:main Sep 12, 2024
17 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants