-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete schema elements that don't match target OpenSearch version. #428
Conversation
Changes AnalysisCommit SHA: 7cf2517 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10104069658/artifacts/1742071927 API Coverage
|
c86af16
to
fcbedee
Compare
9bc5996
to
5edc5ba
Compare
2bd2fd6
to
c0d194b
Compare
36b5cee
to
47e5737
Compare
cc915a2
to
19e41ee
Compare
Spec Test Coverage Analysis
|
7136d8a
to
06c7feb
Compare
@nhtruong I think I addressed all the feedback. The updated implementation will delete all refs that don't match semver, then purge all unused refs and finally purge all objects that reference all refs that were removed for the entire resulting spec. |
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Description
This change allows us to generates a merged spec that targets a specific version without all the unnecessary parts. It accomplishes a number of goals.
x-version-removed
before the target server version orx-version-added
after, effectively testing that the values of these fields are correct.x-version
fields from consumers of the spec. This would allow us to maintain stable releases of clients that are only compatible with OpenSearch 1.x for example with only fixes, without adding any 2.x methods to them.This removes non-matching parameters.
and entire operations
Issues Resolved
Closes #425.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.