Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding specs for SQL namespace #379

Merged
merged 28 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
678fbdf
added sql query specification
Tokesh Jul 7, 2024
36b6c48
lint of query params
Tokesh Jul 7, 2024
2a61bed
added explain, close and stats API specs
Tokesh Jul 8, 2024
6af8316
small fix of x-operation group
Tokesh Jul 8, 2024
108d0a0
fixing lint errors
Tokesh Jul 8, 2024
a0965bc
small fix of operation group
Tokesh Jul 8, 2024
df6c0ff
Revert "fix operation xgroup"
Tokesh Jul 8, 2024
225447d
fix response body
Tokesh Jul 8, 2024
aa51113
response body not passing linter
Tokesh Jul 8, 2024
68752e2
response body
Tokesh Jul 8, 2024
374e0e6
deleting unnecessary response body
Tokesh Jul 8, 2024
73974e7
adding first test for SQL query api
Tokesh Jul 8, 2024
a615da8
deleting local parameters for testing
Tokesh Jul 8, 2024
cb81586
adding tests for sql namespace
Tokesh Jul 21, 2024
7ae06fb
fixing tests for sql namespace
Tokesh Jul 21, 2024
7efd2bb
fixing lint
Tokesh Jul 21, 2024
a9b20c5
fixing status in request body of sql query API
Tokesh Jul 24, 2024
f2ab07e
Merge branch 'main' into sql-namespace
Tokesh Jul 24, 2024
ebddcef
hotfix of sql query structure
Tokesh Jul 24, 2024
7a075cd
Merge remote-tracking branch 'refs/remotes/origin/sql-namespace' into…
Tokesh Jul 24, 2024
a14a618
fix structure of sql stats API
Tokesh Jul 24, 2024
f3003df
fix linter, descriptions
Tokesh Jul 24, 2024
bf278c8
fixing specs-validate ci
Tokesh Jul 24, 2024
ede9aba
adding verbose to check error in tests
Tokesh Jul 24, 2024
0c29ed7
adding second document to receive cursor
Tokesh Jul 24, 2024
8514dfd
added bulk in close API tests, description of PR to changelog, deleti…
Tokesh Jul 24, 2024
8cd485b
adding author name to cspell
Tokesh Jul 24, 2024
1573d8b
adding text to changelog and refactoring code from chapters to prologue
Tokesh Jul 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cspell
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,6 @@ urldecode
vectory
whoamiprotected
wordnet
datarows
syserr
cuserr
6 changes: 3 additions & 3 deletions spec/namespaces/sql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ paths:
operationId: sql.query.0
x-operation-group: sql.query
x-version-added: '1.0'
description: Sends an SQL/PPL query to the SQL plugin.
description: Send a SQL/PPL query to the SQL plugin.
externalDocs:
url: https://opensearch.org/docs/latest/search-plugins/sql/sql-ppl-api/
parameters:
Expand Down Expand Up @@ -41,7 +41,7 @@ paths:
operationId: sql.close.0
x-operation-group: sql.close
x-version-added: '1.0'
description: To explicitly clear the cursor context.
description: Clears the cursor context.
nhtruong marked this conversation as resolved.
Show resolved Hide resolved
externalDocs:
url: https://opensearch.org/docs/latest/search-plugins/sql/sql-ppl-api/
parameters:
Expand All @@ -57,7 +57,7 @@ paths:
operationId: sql.get_stats.0
x-operation-group: sql.get_stats
x-version-added: '1.0'
description: By a stats endpoint, you are able to collect metrics for the plugin within the interval.
description: Collect metrics for the plugin within the interval.
externalDocs:
url: https://opensearch.org/docs/latest/search-plugins/sql/monitoring/
parameters:
Expand Down
2 changes: 1 addition & 1 deletion tests/_core/bulk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ chapters:
- {update: {_index: books, _id: book_1392214}}
- {doc: {pages: 376}, _source: true}
- {update: {_index: books, _id: book_1392214}}
- {script: {source: 'ctx._source.pages = 376;'}}
- {script: {source: ctx._source.pages = 376;}}
- {update: {_index: books, _id: does_not_exist}}
- {script: {source: 'ctx.op = "none";'}, scripted_upsert: true, upsert: {pages: 375}}
- {delete: {_index: books, _id: book_1392214}}
Expand Down
4 changes: 2 additions & 2 deletions tests/sql/close.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ chapters:
request_body:
payload:
fetch_size: 1
query: "SELECT * FROM books"
query: 'SELECT * FROM books'
response:
status: 200
output:
cursor: 'payload.cursor'
cursor: payload.cursor
- synopsis: Close cursor
path: /_plugins/_sql/close
method: POST
Expand Down
2 changes: 1 addition & 1 deletion tests/sql/query.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ chapters:
method: POST
request_body:
payload:
query: "SELECT * FROM books"
query: 'SELECT * FROM books'
response:
status: 200
Loading