Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate order of operations in spec operations. #325

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 7, 2024

Description

Checks that operations are ordered the same way.

Issues Resolved

One half of #272.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock marked this pull request as ready for review June 7, 2024 19:11
@dblock dblock added the skip-changelog No need to update CHANGELOG. label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

Changes Analysis

Commit SHA: 27aed1c
Comparing To SHA: 64b747c

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9421992894/artifacts/1580340928

API Coverage

Before After Δ
Covered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Uncovered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Unknown 24 24 0

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (64b747c) to head (27aed1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   88.74%   89.50%   +0.75%     
==========================================
  Files          40       40              
  Lines        1164     1172       +8     
  Branches      260      285      +25     
==========================================
+ Hits         1033     1049      +16     
+ Misses        124      109      -15     
- Partials        7       14       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock changed the title Validate order of operations. Validate order of operations in spec operations. Jun 7, 2024
@nhtruong nhtruong merged commit e6597c0 into opensearch-project:main Jun 7, 2024
12 of 21 checks passed
@dblock dblock deleted the validate-order-of-operations branch June 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants