Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PR workflow with a release draft. #211

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 1, 2024

Description

I propose we replace the checked in ../builds/OpenSearch.latest.yaml with a release draft workflow.

Here's what it produces: https://github.com/dblock/opensearch-api-specification/releases/tag/latest-draft-release

Screenshot 2024-04-01 at 5 10 56 PM

This avoids having to have another PR behind every change to update the spec, and lets you have separate builds per branch.

Note coverage in this PR is failing because I moved builds -> build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nhtruong
Copy link
Collaborator

nhtruong commented Apr 1, 2024

Looks good to me.
Would we be able to pull the ./build/Opensearch.latest.yaml file with a curl command while it's still in draft release? It'll be useful to be able to do that and test the changes with a client generator before finalizing the release.

@dblock
Copy link
Member Author

dblock commented Apr 1, 2024

Would we be able to pull the ./build/Opensearch.latest.yaml file with a curl command while it's still in draft release? It'll be useful to be able to do that and test the changes with a client generator before finalizing the release.

Yes, try https://github.com/dblock/opensearch-api-specification/releases/download/latest-draft-release/OpenSearch.latest.yaml

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@dblock
Copy link
Member Author

dblock commented Apr 2, 2024

Closing in favor of #213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants