Fixed spec to make it inline with server #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
dblock,
harshavamsi,
pgtgrly,
sachetalva,
nhtruong,
Xtansia and
VachaShah
as code owners
VachaShah
reviewed
Oct 11, 2023
| @@ -21,6 +21,7 @@ list PitIds{ | |||
| } | |||
|
|
|||
|
|
|||
| @documentation("a point-in-time id to delete") | |||
There was a problem hiding this comment.
Lets keep the documentation consistent. One example: https://github.com/opensearch-project/opensearch-api-specification/blob/037843f96c36349b943514ffb59198d9c0855296/model/indices/put_alias/structures.smithy#L23C1-L23C1. May be we can write "The point-in-time ids to be deleted".
Signed-off-by: saimedhi <[email protected]>
|
@VachaShah can you please take a look and let me know if any more changes are required |
VachaShah
approved these changes
Oct 12, 2023
|
@Xtansia, can you please take a look. |
Xtansia
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed spec to make it inline with server
Issues Resolved
Related to #155
Related to #159
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.