Use adminClient instead of client when interacting with system index in integTests #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in integTests Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt,
jowg-amazon,
r1walz and
vikasvb90
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
5 tasks
Signed-off-by: Craig Perkins <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management/backport-2.x
# Create a new branch
git switch --create backport/backport-1222-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b7ddbb693128e5de31482a0d2bc8c16eef710662
# Push it to GitHub
git push --set-upstream origin backport/backport-1222-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management/backport-2.xThen, create a pull request where the |
|
@cwperks auto backport failing, mind create one manually? |
👍 , yes I will create a manual backport in a few hours. |
cwperks
added a commit
to cwperks/index-management
that referenced
this pull request
Aug 2, 2024
…in integTests (opensearch-project#1222) (cherry picked from commit b7ddbb6)
74 tasks
3 tasks
cwperks
added a commit
that referenced
this pull request
Aug 22, 2024
…h system index in integTests (#1222) (#1223) * Use adminClient instead of client when interacting with system index in integTests (#1222) (cherry picked from commit b7ddbb6) * Switch to APPLICATION_JSON Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR to attempt to fix security CI checks. There are a few instances where the
adminClientshould be used instead ofclientin integTests.To test I am running a local node with security, JS + ISM installed.
Running tests with
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.