Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET SM policies return empty list when ism config index does not exist #1072

Merged
merged 5 commits into from
Jan 24, 2024
Merged

GET SM policies return empty list when ism config index does not exist #1072

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
415f374
Fix for GET request on SM policies to return empty list when ism conf…
aggarwalShivani Jan 8, 2024
8725986
Merge branch 'main' into sm-missing-index-fix
aggarwalShivani Jan 16, 2024
2ac032a
Update getAllPolicies in TransportGetSMPoliciesAction.kt
aggarwalShivani Jan 17, 2024
4320a53
Added test case for the change and handled exception with ExceptionsH…
aggarwalShivani Jan 18, 2024
7a63a9d
Modified ExceptionsHelper.unwrapCause handling for Exception
aggarwalShivani Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...arch/indexmanagement/snapshotmanagement/api/transport/get/TransportGetSMPoliciesAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ class TransportGetSMPoliciesAction @Inject constructor(

private suspend fun getAllPolicies(searchParams: SearchParams, user: User?): Pair<List<SMPolicy>, Long> {
val searchRequest = getAllPoliciesRequest(searchParams, user)
val searchResponse: SearchResponse = try {
client.suspendUntil { search(searchRequest, it) }
return try {
val searchResponse = client.suspendUntil { search(searchRequest, it) }
parseGetAllPoliciesResponse(searchResponse)
} catch (e: IndexNotFoundException) {
aggarwalShivani marked this conversation as resolved.
Show resolved Hide resolved
throw OpenSearchStatusException("Snapshot management config index not found", RestStatus.NOT_FOUND)
// config index hasn't been initialized, catch this here and show empty result for policies
Pair(emptyList(), 0L)
} catch (e: Exception) {
throw e
}
return parseGetAllPoliciesResponse(searchResponse)
}

private fun getAllPoliciesRequest(searchParams: SearchParams, user: User?): SearchRequest {
Expand Down
Loading