Setting validation for transform APIs #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
- Coverage 61.61% 60.96% -0.65%
==========================================
Files 345 347 +2
Lines 12449 12831 +382
Branches 2509 2588 +79
==========================================
+ Hits 7671 7823 +152
- Misses 4075 4269 +194
- Partials 703 739 +36 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kshitij Tandon <[email protected]>
sarthakaggarwal97
approved these changes
Oct 25, 2024
Signed-off-by: Kshitij Tandon <[email protected]>
SuZhou-Joe
approved these changes
Oct 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Enabling validation for transform APIs Signed-off-by: Kshitij Tandon <[email protected]> * Updating snap files Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some of the updated snap files from previous commit Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes to test workflows Signed-off-by: Kshitij Tandon <[email protected]> * Change workflows java version to 21 from 11 Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes done just to test the workflows Signed-off-by: Kshitij Tandon <[email protected]> * Updating vaidation rules and tests Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue with API validation Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit fd0e765) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Enabling validation for transform APIs Signed-off-by: Kshitij Tandon <[email protected]> * Updating snap files Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some of the updated snap files from previous commit Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes to test workflows Signed-off-by: Kshitij Tandon <[email protected]> * Change workflows java version to 21 from 11 Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes done just to test the workflows Signed-off-by: Kshitij Tandon <[email protected]> * Updating vaidation rules and tests Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue with API validation Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit fd0e765) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Oct 28, 2024
* Setting validation for transform APIs (#1191) * Enabling validation for transform APIs Signed-off-by: Kshitij Tandon <[email protected]> * Updating snap files Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some of the updated snap files from previous commit Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes to test workflows Signed-off-by: Kshitij Tandon <[email protected]> * Change workflows java version to 21 from 11 Signed-off-by: Kshitij Tandon <[email protected]> * Reverting some changes done just to test the workflows Signed-off-by: Kshitij Tandon <[email protected]> * Updating vaidation rules and tests Signed-off-by: Kshitij Tandon <[email protected]> * Fixing an issue with API validation Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit fd0e765) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: use fixed version Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Enabling validation for transform APIs * Updating snap files * Reverting some of the updated snap files from previous commit * Reverting some changes to test workflows * Change workflows java version to 21 from 11 * Reverting some changes done just to test the workflows * Updating vaidation rules and tests * Fixing an issue with API validation --------- (cherry picked from commit fd0e765) Signed-off-by: Kshitij Tandon <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting validation for couple of transform APIs
/api/ism/transforms/_preview: Have added validations to ensure that body parameter are of a specific type only and also the indexes names and datasourceId should have a specifed range of length and should consist of some particular characters only
/api/ism/_searchSampleData/{index}: Similarly have added validations for datasourceId and index name
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.