Fit and finish changes for Aliases, Templates and Policy managed Indices pages #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
tandonks
changed the title
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
force-pushed
the
fitfinishAliases
branch
from
1bd9788
to
c49417e
Compare
|
Is this modal in scope? |
|
Header size in 
|
|
A few modals in Templates use the SimpleModal in
|
|
This flyout in 
|
|
Is the header in 
|
|
The text in 
|
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
force-pushed
the
fitfinishAliases
branch
from
4d39d13
to
c1a4cc5
Compare
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
There was a problem hiding this comment.
Should the "You have no templates." text here on line 337 be <EuiText size="s">?
Signed-off-by: Kshitij Tandon <[email protected]>
danieldong51
approved these changes
Aug 30, 2024
Signed-off-by: Kshitij Tandon <[email protected]>
SuZhou-Joe
approved these changes
Sep 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…ces pages (#1155) * Changes for Aliases, templates & policy managed indices Signed-off-by: Kshitij Tandon <[email protected]> * Added snap files Signed-off-by: Kshitij Tandon <[email protected]> * Resolved a failing UT Signed-off-by: Kshitij Tandon <[email protected]> * Updated couple of snap files Signed-off-by: Kshitij Tandon <[email protected]> * Fixed a few bugs and worked on comments Signed-off-by: Kshitij Tandon <[email protected]> * Updated Snap files Signed-off-by: Kshitij Tandon <[email protected]> * Worked on reviews Signed-off-by: Kshitij Tandon <[email protected]> * Couple of changes for old UI Signed-off-by: Kshitij Tandon <[email protected]> * Minor changes to UI Signed-off-by: Kshitij Tandon <[email protected]> * Title changes in Old UI Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit b08be46) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 2, 2024
…ces pages (#1155) (#1158) * Changes for Aliases, templates & policy managed indices * Added snap files * Resolved a failing UT * Updated couple of snap files * Fixed a few bugs and worked on comments * Updated Snap files * Worked on reviews * Couple of changes for old UI * Minor changes to UI * Title changes in Old UI --------- (cherry picked from commit b08be46) Signed-off-by: Kshitij Tandon <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
astute-decipher
pushed a commit
to astute-decipher/index-management-dashboards-plugin
that referenced
this pull request
Sep 2, 2024
…ces pages (opensearch-project#1155) * Changes for Aliases, templates & policy managed indices Signed-off-by: Kshitij Tandon <[email protected]> * Added snap files Signed-off-by: Kshitij Tandon <[email protected]> * Resolved a failing UT Signed-off-by: Kshitij Tandon <[email protected]> * Updated couple of snap files Signed-off-by: Kshitij Tandon <[email protected]> * Fixed a few bugs and worked on comments Signed-off-by: Kshitij Tandon <[email protected]> * Updated Snap files Signed-off-by: Kshitij Tandon <[email protected]> * Worked on reviews Signed-off-by: Kshitij Tandon <[email protected]> * Couple of changes for old UI Signed-off-by: Kshitij Tandon <[email protected]> * Minor changes to UI Signed-off-by: Kshitij Tandon <[email protected]> * Title changes in Old UI Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fit and finish changes for Aliases, Templates and Policy managed Indices pages
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.