Making fit and finish changes for ISM policy & Composable template pages #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astute-decipher
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
|
LGTM. Gone through the pages offline. |
|
Not sure if it's in scope, but the Delete Modal header and text should be 
|
|
Also the Delete Policy in |
|
Also not sure if in scope, but the Modal header should be small h2's in |
|
The Text in 
|
public/pages/VisualCreatePolicy/components/ISMTemplates/ISMTemplates.tsx
Show resolved
Hide resolved
public/pages/VisualCreatePolicy/containers/VisualCreatePolicy/VisualCreatePolicy.tsx
Show resolved
Hide resolved
astute-decipher
force-pushed
the
fitnfinish
branch
from
bfd8260
to
ffd4951
Compare
added 11 commits
September 2, 2024 15:14
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
astute-decipher
force-pushed
the
fitnfinish
branch
from
ffd4951
to
7147749
Compare
SuZhou-Joe
approved these changes
Sep 2, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1150-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 44260f640fb141be17a6e673d3242696eec0e1d3
# Push it to GitHub
git push --set-upstream origin backport/backport-1150-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.xThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ges (#1150) * Fit and finish changes ISM Signed-off-by: Shubh Sahu <[email protected]> * more fit changes Signed-off-by: Shubh Sahu <[email protected]> * final fit n finish changes Signed-off-by: Shubh Sahu <[email protected]> * final fit n finish changes Signed-off-by: Shubh Sahu <[email protected]> * few more small changes Signed-off-by: Shubh Sahu <[email protected]> * more fit changes Signed-off-by: Shubh Sahu <[email protected]> * final fit n finish changes Signed-off-by: Shubh Sahu <[email protected]> * final fitnfinsh changes complete Signed-off-by: Shubh Sahu <[email protected]> * adding plus icon Signed-off-by: Shubh Sahu <[email protected]> * rebaseing Signed-off-by: Shubh Sahu <[email protected]> * rebasing 2.0 Signed-off-by: Shubh Sahu <[email protected]> --------- Signed-off-by: Shubh Sahu <[email protected]> Co-authored-by: Shubh Sahu <[email protected]> (cherry picked from commit 44260f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ges (#1150) (#1162) * Fit and finish changes ISM * more fit changes * final fit n finish changes * final fit n finish changes * few more small changes * more fit changes * final fit n finish changes * final fitnfinsh changes complete * adding plus icon * rebaseing * rebasing 2.0 --------- (cherry picked from commit 44260f6) Signed-off-by: Shubh Sahu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shubh Sahu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making fit and finish changes for ISM policy & Composable template pages according to the guidance
Issues Resolved
[List any issues this PR will resolve]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.