[Backport 2.x] Remove useCase and defaultParams field in WorkflowRequest (#952) #954
+12
−194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#952) * Remove useCase and defaultParams field in WorkflowRequest Signed-off-by: Junwei Dai <[email protected]> * Remove useCase and defaultParams field in WorkflowRequest Signed-off-by: Junwei Dai <[email protected]> * Removed the constructor that has never been used and tested. Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit 219aec5)
…-project#952) * Remove useCase and defaultParams field in WorkflowRequest Signed-off-by: Junwei Dai <[email protected]> * Remove useCase and defaultParams field in WorkflowRequest Signed-off-by: Junwei Dai <[email protected]> * Removed the constructor that has never been used and tested. Signed-off-by: Junwei Dai <[email protected]> --------- Signed-off-by: Junwei Dai <[email protected]> Co-authored-by: Junwei Dai <[email protected]> (cherry picked from commit 219aec5)
junweid62
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Junwei Dai <[email protected]>
owaiskazi19
approved these changes
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #954 +/- ##
=========================================
Coverage 78.07% 78.08%
+ Complexity 996 993 -3
=========================================
Files 99 99
Lines 4625 4617 -8
Branches 431 431
=========================================
- Hits 3611 3605 -6
+ Misses 834 832 -2
Partials 180 180 ☔ View full report in Codecov by Sentry. |
dbwiddis
changed the title
dbwiddis
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 219aec5 from #952