Add query assist data summary agent template #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liyun Xiu <[email protected]>
Signed-off-by: Liyun Xiu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=========================================
Coverage 77.55% 77.55%
Complexity 966 966
=========================================
Files 97 97
Lines 4531 4531
Branches 422 422
=========================================
Hits 3514 3514
Misses 835 835
Partials 182 182 ☔ View full report in Codecov by Sentry. |
chishui
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
reviewed
Sep 18, 2024
Comment on lines
+34
to
+38
| "credential": { | ||
| "access_key": "<YOUR_ACCESS_KEY>", | ||
| "secret_key": "<YOUR_SECRET_KEY>", | ||
| "session_token": "<YOUR_SESSION_TOKEN>" | ||
| }, |
There was a problem hiding this comment.
Not a comment on this PR, but note to other reviewers. I wonder if there's a way we can (probably in ML Commons) not require these to be specified in the connector, but instead have them pulled in real time using CredentialsProviders like the AWS SDK client does.
Signed-off-by: Liyun Xiu <[email protected]>
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add query assist data summary agent template
Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.