[Backport 2.x] feat: parse connector id from tool parameters map #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* feat: parse connector id from tool parameters map Signed-off-by: yuye-aws <[email protected]> * update changelog Signed-off-by: yuye-aws <[email protected]> * implement unit test for connector, model and agent id Signed-off-by: yuye-aws <[email protected]> * tool step id: make node id unique Signed-off-by: yuye-aws <[email protected]> * integration test: create agent with connector tool Signed-off-by: yuye-aws <[email protected]> * integration test: update with get agent and get workflow Signed-off-by: yuye-aws <[email protected]> * optimize: iterate through connector_id model_id and agent_id Signed-off-by: yuye-aws <[email protected]> * update changelog Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit b3f9d65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Aug 28, 2024
Signed-off-by: Daniel Widdis <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #848 +/- ##
============================================
+ Coverage 77.44% 77.55% +0.10%
- Complexity 963 966 +3
============================================
Files 97 97
Lines 4536 4531 -5
Branches 423 422 -1
============================================
+ Hits 3513 3514 +1
+ Misses 841 835 -6
Partials 182 182 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b3f9d65 from #846.