Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Handle Not Found deprovision exceptions as successful deletions #806

Merged
merged 1 commit into from
Jul 25, 2024

Handle Not Found deprovision exceptions as successful deletions (#805)

359319d
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] Handle Not Found deprovision exceptions as successful deletions #806

Handle Not Found deprovision exceptions as successful deletions (#805)
359319d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 25, 2024 in 0s

75.69% (+0.01%) compared to 2996e7d

View this Pull Request on Codecov

75.69% (+0.01%) compared to 2996e7d

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (2996e7d) to head (359319d).

Files Patch % Lines
...search/flowframework/workflow/DeleteAgentStep.java 75.00% 0 Missing and 2 partials ⚠️
...search/flowframework/workflow/DeleteModelStep.java 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #806      +/-   ##
============================================
+ Coverage     75.68%   75.69%   +0.01%     
- Complexity      833      834       +1     
============================================
  Files            88       88              
  Lines          4035     4045      +10     
  Branches        371      373       +2     
============================================
+ Hits           3054     3062       +8     
  Misses          828      828              
- Partials        153      155       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.