Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflow step resource updates to eliminate duplication #796

Merged
merged 2 commits into from
Aug 14, 2024

Add coverage and changelog

2648713
Select commit
Loading
Failed to load commit list.
Merged

Refactor workflow step resource updates to eliminate duplication #796

Add coverage and changelog
2648713
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 12, 2024 in 0s

77.30% (+1.92%) compared to 268f746

View this Pull Request on Codecov

77.30% (+1.92%) compared to 268f746

Details

Codecov Report

Attention: Patch coverage is 93.18182% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.30%. Comparing base (268f746) to head (2648713).

Files Patch % Lines
...framework/indices/FlowFrameworkIndicesHandler.java 77.77% 4 Missing ⚠️
...ework/workflow/AbstractRegisterLocalModelStep.java 88.88% 1 Missing ⚠️
...search/flowframework/workflow/CreateIndexStep.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #796      +/-   ##
============================================
+ Coverage     75.38%   77.30%   +1.92%     
- Complexity      917      922       +5     
============================================
  Files            96       96              
  Lines          4456     4345     -111     
  Branches        412      412              
============================================
  Hits           3359     3359              
+ Misses          925      814     -111     
  Partials        172      172

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov